From 50f87dda4e494297d720f7dde70a11bc27ffe099 Mon Sep 17 00:00:00 2001 From: Efe Karasakal Date: Fri, 23 Oct 2026 20:06:33 +0200 Subject: [PATCH 1/2] quic: fix internal error code conversion Signed-off-by: Efe Karasakal --- src/quic/session.cc | 2 +- src/quic/streams.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/quic/session.cc b/src/quic/session.cc index ba672a3bee48..1d06b1fdcc00 100644 --- a/src/quic/session.cc +++ b/src/quic/session.cc @@ -3649,7 +3649,7 @@ void Session::SendConnectionClose() { auto ErrorAndSilentClose = [&] { Debug(this, "Failed to create connection close packet"); - SetLastError(QuicError::ForNgtcp2Error(NGTCP2_INTERNAL_ERROR)); + SetLastError(QuicError::ForNgtcp2Error(NGTCP2_ERR_INTERNAL)); Close(CloseMethod::SILENT); }; diff --git a/src/quic/streams.cc b/src/quic/streams.cc index 0a2af12d366a..6b2da56309f6 100644 --- a/src/quic/streams.cc +++ b/src/quic/streams.cc @@ -703,7 +703,7 @@ class Stream::Outbound final : public MemoryRetainer { if (flags_.next_pending) { flags_.next_pending = false; stream_->Destroy( - QuicError::ForNgtcp2Error(NGTCP2_INTERNAL_ERROR)); + QuicError::ForNgtcp2Error(NGTCP2_ERR_INTERNAL)); // We do not need to worry about calling MarkErrored in this case // since we are immediately destroying the stream which will // release the outbound buffer anyway. From dcc3a67e478da2a3d5e3841497072ba672c88e3c Mon Sep 17 00:00:00 2001 From: Efe Karasakal Date: Fri, 23 Oct 2026 20:13:50 +0200 Subject: [PATCH 2/2] quic: fmt Signed-off-by: Efe Karasakal --- src/quic/streams.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/quic/streams.cc b/src/quic/streams.cc index 6b2da56309f6..c62ceeb2a8e3 100644 --- a/src/quic/streams.cc +++ b/src/quic/streams.cc @@ -702,8 +702,7 @@ class Stream::Outbound final : public MemoryRetainer { // but we have an error! oh no! We need to error the stream. if (flags_.next_pending) { flags_.next_pending = false; - stream_->Destroy( - QuicError::ForNgtcp2Error(NGTCP2_ERR_INTERNAL)); + stream_->Destroy(QuicError::ForNgtcp2Error(NGTCP2_ERR_INTERNAL)); // We do not need to worry about calling MarkErrored in this case // since we are immediately destroying the stream which will // release the outbound buffer anyway.