Skip to content

fix: allow blank and null values for remark field in ApplicationKeySerializer #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Oct 28, 2026
Merged

fix: allow blank and null values for remark field in ApplicationKeySerializer #7523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/serializers/application_api_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class EditApplicationKeySerializer(serializers.Serializer):
)
is_permanent = serializers.BooleanField(required=False, label=_("Is permanent"))
expire_time = serializers.DateTimeField(required=False, allow_null=True, label=_("Expiration time"))
remark = serializers.CharField(required=False, label=_("Remark"))
remark = serializers.CharField(required=False, allow_null=True, allow_blank=True, label=_("Remark"))


class ApplicationKeySerializer(serializers.Serializer):
Expand Down
11 changes: 11 additions & 0 deletions apps/application/tests/test_application_api_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from django.test import SimpleTestCase

from application.serializers.application_api_key import EditApplicationKeySerializer


class EditApplicationKeySerializerTests(SimpleTestCase):
def test_accepts_blank_remark(self):
serializer = EditApplicationKeySerializer(data={"remark": ""})

self.assertTrue(serializer.is_valid())
self.assertEqual(serializer.validated_data["remark"], "")
Loading