Repository navigation
fix(scrollbar): place thumb correctly when it reappears - #3003
Merged
Merged
Conversation
The value was set while the scrollbar was detached, so it was measured against an empty rect and painted at 0 for a frame. Only check the track along the scroll axis, and measure again after appending.
Contributor
 [Medium impact] The PR appears safe to merge; the previous stale-width issue is fixed and no new actionable issues were found. SummaryFixes the scrollbar thumb flashing at the top when it reappears.
Reviews (2) · Last reviewed commit: "fix(scrollbar): measure the track on eve..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The parent can change size without a window resize (e.g. the sidebar opening), so a cached track length can go stale.
This comment was marked as outdated.
This comment was marked as outdated.
github-project-automation
Bot
moved this from Backlog
to Done
in The Code Board - Acode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3000 - the scrollbar thumb flashed at the top for a moment when it reappeared after fading out.