Repository navigation
teams page: show a team's total live cost, as a figure of its own - #1916
Draft
ZeroPoint95 wants to merge 1 commit into
Draft
ZeroPoint95 wants to merge 1 commit into
ZeroPoint95 wants to merge 1 commit into
Conversation
Assisted-by: CodeAF Co-Authored-By: CodeAF <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
$1.20 of $5 todaycap reading left alone in the header strip.Teams.Totaldelegation door behind the additiveWelcome.TeamsTotalflag answers the same stamp as the day's spend so a quiet ledger costs no read, andMember.LeftAtis stamped at removal so the team keeps a former member's spend while they were in it and nothing after; a removal written before the field existed counts from JoinedAt on.Closes #1878.
Validation
cd . && go test ./internal/tui3/ -run 'TeamsRailRowCarriesTheTeamsOwnTotal|TeamsPaneBodyDrawsTheTotalBesideTheDaysSpend|TeamsSettingsCardShowsTheTotalAndThePerMemberShare|TeamsWithNoTotalDoorDrawsNoTotals|TestLowCreditReadSwapsOnlyAnUntouchedImplicitConversation' -count=1 -v 2>&1 | grep -E '^(--- PASS|--- FAIL|ok |FAIL)' ; echo "target-exit=$?".cd . && go test ./internal/teams/ -run 'TestTeamTotalWholeChainsMembershipAndSubtree|TestTeamTotalOfALedgerThatAppearsAfterAMissingRead|TestTeamTotalLegacyFormerMemberWithoutLeftAtCountsFromJoinedAt|TestRemoveMemberStampsLeftAt|TestMemberLeftAtRoundTripKeepsUnknownFields' -count=1 -v 2>&1 | grep -E '^(--- PASS|--- FAIL|ok |FAIL)'; echo "named-exit=$?".tail -3 /tmp/proof-tui3-full.log && grep -c '^--- FAIL' /tmp/proof-tui3-full.log; echo "---"; cd . && go test ./cmd/codeaf/ -run 'TestTheTotalDoorCrossesHostOnlyWhenTheEngineSaysSo|TestAnOlderEngineGetsNoTeamsSeam' -count=1 -v 2>&1 | grep -E '^(--- PASS|--- FAIL|ok |FAIL)'; echo "doors-exit=$?".$67.46/$12and never the cap's 'of $' figure; the pane body drawstotal $67.46 · $1.20 of $5 todayfor an open team andtotal $67.46 · $1.20 todayfor a closed one while the strip keeps the cap piece; the Settings card draws 'Total cost $67.46' plus each member's share including a former member's ($1.99 under @gone); and over a seam without the Total door (older engine) the page asks for, folds and draws no totals while the day's spend still crosses.by codeaf factory
Factory-Approval: evt_24be7e0f @ZeroPoint95 a1eb97e