Repository navigation
ci: run pytest with its default capture on Windows (drop --capture=sys) - #87
Merged
Merged
Conversation
…pture=sys) PR #78 made engine logs go to the log file only on Windows, which removes the cause of humemai/arcadedb-embedded-python#10. This branch is for the dispatch runs that show it. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows runs pytest with its default capture again, so
--capture=sysis gone from.github/workflows/test-jvm.yml.--capture=syswas added for humemai/arcadedb-embedded-python#10: pytest's default fd capture swaps fds 1 and 2 withdup2around every test, which on Windows closed the OS handle the JVM had cached forSystem.out/System.err, and the next Java log line blocked forever inWriteFile(caught on 2026-09-29, inLSMVectorIndex.build's progress log). #78 made the engine log to the log file only on Windows (ARCADEDB_LOG_CONSOLE,src/arcadedb/_logdir.py), which removes the cause, and the workflow comment already said the flag would go once a run with the default capture passed on the Windows legs.Merge condition
Do not merge before both dispatch runs of this branch, all legs, are green on the Windows legs with no hang (the pytest step has a 30 minute limit) and no failure: 40250608731 and 40250615309. If either hangs or fails, keep the flag instead: put it back and replace the comment with what still breaks and the run ids.
The branch only changes the comment and the pytest command, so the rest of the legs say nothing about this.
🤖 Generated with Claude Code