Repository navigation
fix(account): register through the Build registration API - #57
Merged
Merged
Conversation
`band account register`, `send-code`, and `verify` still posted to the legacy express-registration-service endpoints under /v1/express/registration. That service is being decommissioned, and its routes will start returning 404. Point RegistrationHost at /v1/build and use the plural /registrations paths that express-billing-service serves. The request bodies and response envelopes are unchanged: billing accepts the same fields (phoneNumber, email, firstName, lastName, tosAccepted, promotionalCommsAccepted; deliveryChannel SMS|VOICE; code) and returns the same message/status/registrationId data. Register now reports USER_CREATION_INITIATED instead of USER_CREATION_PENDING. Co-Authored-By: Claude Opus 5.5 <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kylefirman
approved these changes
Oct 22, 2026
michaela-band
approved these changes
Oct 22, 2026
matthewkmartin
approved these changes
Oct 22, 2026
venkatsram
approved these changes
Oct 22, 2026
ajrice6713
approved these changes
Oct 23, 2026
brianluisgomez
approved these changes
Oct 23, 2026
aknight-bw
approved these changes
Oct 23, 2026
mkeathley-bw
approved these changes
Oct 23, 2026
noahg1
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
band account register,band account send-code, andband account verifynow call the Build registration API (/v1/build/registrations*) instead of the legacy/v1/express/registration*endpoints, which are being retired (BUILD-513).RegistrationHost()returns<api host>/v1/build.BW_API_URLstill overrides the host./registrations,/registrations/codeand/registrations/code/verify.Why
The legacy registration endpoints are being decommissioned and will start returning 404. Every CLI release up to and including
v0.5.2-betauses them, so CLI signups will fail until users upgrade to a release containing this change.Compatibility
No flag or output changes. The Build API accepts the same request bodies the CLI already sends and returns the same
message/status/registrationIdenvelope:registerphoneNumber,email,firstName,lastName,tosAccepted,promotionalCommsAcceptedsend-codephoneNumber,email,deliveryChannel(SMS|VOICE, already upper-cased by the CLI)verifyphoneNumber,email,codeThe only visible difference is that
registernow reportsUSER_CREATION_INITIATEDrather thanUSER_CREATION_PENDING. It may also return201instead of200; the client already treats any 2xx as success.Testing
go build ./...,go vet ./..., andgo test ./...all pass (1270 tests)RegistrationHost(): the default host, and aBW_API_URLoverride with a trailing slashgolangci-lintcouldn't run locally, because the local binary was built with Go 1.27.0 and this repo requires 1.27.3; it fails the same way onmain. CI covers it.Release note
Users on
v0.5.2-betaor earlier need to upgrade to register through the CLI once the legacy endpoints are removed.🤖 Generated with Claude Code