Repository navigation
Change the method of get file extension. #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myafer
wants to merge
18
commits into
Baseflow:main
Choose a base branch
from
myafer:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+218
−15
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4e03901
1
myafer 74e71ca
Update file_service_compat.dart
myafer b6105f7
Update image_cache_manager.dart
myafer 6028618
fix: fix method name
myafer 4ec2651
Update build.gradle
myafer b8ebe93
Update build.gradle
myafer 1d73d2e
1
myafer 64ff206
Update build.gradle
myafer 1a55b01
Update build.gradle
myafer b0ed040
Merge main into develop
rickdijk 2132fb4
fix(image): detect resizable images by content instead of url extension
myafer 3a498ba
fix(image): also detect bmp by signature and wbmp by extension
myafer a7dac2a
fix(image): match jpeg on its two byte signature
myafer 780d662
fix(image): store the resized image with a png extension
myafer e9eca3a
fix(image): keep an animated webp out of the resizer
myafer fe77da7
docs(image): explain why ico and cur overlap with tga
myafer 02775e7
refactor(image): let the engine decide whether a file can be resized
myafer cd492ed
Merge remote-tracking branch 'upstream/main' into develop
myafer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for the new formats too: resizing a static webp and a bmp, checking that the resized file is stored with a
.pngextension, and that a file that fails to decode is returned untouched? Also note that the 'without file extension' case sets the file name directly, so it doesn't go through the Content-Type path where the real issue occurs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added: a static webp is resized, a bmp is resized, the resized file is asserted to be stored with a
.pngextension, and a file that fails to decode (a json payload served as.png) is returned untouched. Also added tests for animated gif, apng and animated webp being passed through, and for the Content-Type case (png payload served as.bin) you mentioned, since the extension-less test indeed bypasses that path.