Skip to content

fix(recording): say why Windows screen capture could not start - #3493

Merged
richiemcilroy merged 1 commit into
mainfrom
fix/windows-capture-denied-reason
Oct 28, 2026
Merged

richiemcilroy merged 1 commit into
mainfrom
fix/windows-capture-denied-reason

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Summary

  • A Windows 10 user reported that recordings would not start. Every target (display, area, window) failed at CreateCaptureSession with E_ACCESSDENIED, but the app only showed screen pipeline setup: oneshot canceled. The capture thread died before start could hear back, and the real reason only reached the log.
  • When the capture thread cannot create its capturer, it now leaves the reason on the first-frame channel. start returns that reason instead of the cancelled reply.
  • E_ACCESSDENIED from CreateCaptureSession now says that Windows denied Cap access to screen capture, and points at the privacy settings and security software.
  • No timing change: setup still returns straight away, and the success path is untouched.

Test plan

  • Windows build and recording jobs green
  • Recording on Windows starts as before (real-capture CI)

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Windows screen-capture startup now returns the capturer’s failure reason instead of a canceled-channel error.

  • Windows recording startup now shows why screen capture could not start.

No actionable issues found. Windows build and real-capture checks were not run.

Reviews (1) · Last reviewed commit: "fix(recording): say why Windows screen c..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 27, 2026 10:28pm UTC

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

@richiemcilroy
richiemcilroy merged commit bc8dc7d into main Oct 28, 2026
79 of 80 checks passed

This branch was successfully deployed

2 active deployments
Preview – cap-web — 57aa8cfa Deployed Oct 27, 2026 by vercel[bot]
Preview – cap-status — 57aa8cfa Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant