Repository navigation
fix(recording): say why Windows screen capture could not start - #3493
Merged
Merged
Conversation
…d of a cancelled channel
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateCaptureSessionwithE_ACCESSDENIED, but the app only showedscreen pipeline setup: oneshot canceled. The capture thread died beforestartcould hear back, and the real reason only reached the log.startreturns that reason instead of the cancelled reply.E_ACCESSDENIEDfromCreateCaptureSessionnow says that Windows denied Cap access to screen capture, and points at the privacy settings and security software.Test plan


Confidence Score: 5/5
This PR appears safe to merge.Summary
Windows screen-capture startup now returns the capturer’s failure reason instead of a canceled-channel error.
No actionable issues found. Windows build and real-capture checks were not run.
Reviews (1) · Last reviewed commit: "fix(recording): say why Windows screen c..." · Reviewed by Greptile