Repository navigation
fix(desktop-gpui): skip the picker glass capture on Windows display and window pickers - #3525
Merged
Merged
Conversation
…nd window pickers
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
richiemcilroy
marked this pull request as ready for review
October 28, 2026 20:44
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the 0.6.2 display and window pickers show hard-edged lighter blocks behind their glass panels. The target window's content shows through them, and they flicker each time the desktop capture refreshes. In one frame of the display picker, the block held the whole desktop shrunk into the panels' region. 0.6.1 doesn't have this.
Cause
Backdrop::layerpaints the desktop capture under each glass pane, dilated by 24 px. That only blends in when the overlay around the panes lets the live desktop through. On Windows, the display and window pickers composite their target fill as opaque navy. 0.6.1 draws the same navy, so the opaque fill isn't new. Against an opaque fill, the patches of capture show up as visible blocks. The area picker's dim is see-through, so its glass reads correctly.Change
sync_backdropnow asksbackdrop_suits(mode)before it captures. On Windows, the display and window pickers take no capture, and their panes sit on the fallback fill, the same as on Linux, where no capture is possible. Area and camera-only pickers, and macOS everywhere, are unchanged.Testing
windows_display_and_window_pickers_take_no_backdrop.

Confidence Score: 5/5
The PR appears safe to merge.Summary
This PR skips desktop backdrop captures for Windows display and window pickers, so captured desktop patches no longer appear behind their glass panes.
Review was based on code inspection. Tests and native Windows visual checks were not run; the review environment is Linux.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): skip the picker glass..." · Reviewed by Greptile