Repository navigation
Conversation
Next prefetches a dynamic route down to the first loading.tsx on its path, so child routes flashed their parent's skeleton (caps grid on /caps/record, General form on org settings tabs, space grid on space folders) before their own. Move those pages and skeletons into route groups so each loading.tsx covers only its page, and give the Content and Billing settings tabs skeletons that match their layout.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3080. That PR gave
/dashboard/caps/recordits ownloading.tsx, but navigating there still briefly shows the caps grid skeleton first. Next prefetches a dynamic route only down to the firstloading.tsxon its path, andcaps/loading.tsxsits abovecaps/record, so the router shows the parent skeleton until the response arrives with the child's.The same thing happens elsewhere:
/dashboard/caps/record/dashboard/settings/organization/{content,billing}/dashboard/settings/organization/{security,integrations,preferences}/dashboard/spaces/[spaceId]/folder/[folderId]Change
caps/(list)/{page,loading}.tsxsettings/organization/(general)/{page,GeneralPage,loading}.tsxspaces/[spaceId]/(space)/{page,loading}.tsxsecurity,integrations,preferencesre-export the General skeleton as their ownloading.tsx, so they look the same as before without inheriting it.content/loading.tsx(card with source/destination columns) andbilling/loading.tsx(summary card + members list).dashboard-video-count.test.tsandspace-page-round-trips.test.ts.Test plan
vitest runfordashboard-video-count,space-page-round-trips,sso-settings: 71 passedbiome checkclean on touched filesnext build --debug-prerendersucceeds locally (a plain local build fails prerendering/embed,/admin/retry-recordingsand/_global-error, which this PR does not touch)
The changes since the last review appear safe to merge.Summary
The PR moves dashboard loading screens into page-specific route groups and adds separate Content and Billing skeletons.
Reviews (2) · Last reviewed commit: "fix(web): keep settings skeleton bars in..." · Reviewed by Greptile