[ghazy2001]

Summary

Fixes #3502
Linear: CAP-949

When editing a transcript cue in the share page (apps/web/app/s/[videoId]/_components/tabs/Transcript.tsx), saving the edit sends an async update request via updateTranscriptMutation.mutateAsync(...).

While the save request was in flight:

1. The textarea remained enabled and editable. Any characters typed by the user while the mutation was resolving were abruptly overwritten and discarded once the mutation resolved, as Transcript replaced the cue with the saved response snapshot.
2. Clicking other transcript rows or action buttons during save was permitted, risking race conditions and lost edits.
3. If an edit was triggered for a different cue while a previous save was in flight, setEditingEntry(null) cleared the active edit state unconditionally when the previous save completed.

Changes

• apps/web/app/s/[videoId]/_components/tabs/transcript-row.tsx:
  • Bound disabled={isSaving} on the editing <textarea> with disabled:cursor-not-allowed disabled:opacity-50 styling, visually indicating save in flight and preventing user keystrokes from being discarded on settlement.
• apps/web/app/s/[videoId]/_components/tabs/Transcript.tsx:
  • Guarded handleTranscriptClick, startEditing, cancelEditing, and saveEdit against isSaving.
  • Captured entryIdToSave = editingEntry before initiating the async mutation; only clears editingEntry (setEditingEntry(null)) if editingEntry === entryIdToSave when the mutation settles.
  • Passed canEdit={canEdit && !isSaving} to TranscriptRow to disable action buttons while a cue save is in progress.

Test plan

• Ran unit tests with Bun:
  • bun test apps/web/__tests__/unit/transcript-vtt.test.ts (4 passed in 279ms)
  • bun test apps/web/__tests__/unit/transcript-text.test.ts (9 passed in 160ms)
• Verified textarea is disabled during isSaving === true and re-enabled once mutation finishes.
• Verified clicking other cues or cancel while saving does not trigger race conditions or discard draft edits.

Confidence Score: 4/5

Update the existing pending-save test before merging.

Findings

1.  Existing transcript test fails ▶

Fix with agent prompt

### Issue 1
apps/web/app/s/[videoId]/_components/tabs/Transcript.tsx:824
The pending-save test in `share-transcript-rendering.test.ts:299` calls `editCue(3)` while a save is pending. This change removes that row's edit button, so the helper throws `Missing edit button` before the test finishes. Update the test to expect editing to stay blocked, check that the textarea is disabled, and then resolve the save.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR prevents typing and switching transcript rows while a save is pending.

• Transcript edits stay locked until each save finishes.

ghazy2001 explicitly describes blocking other transcript rows during saves as intentional.
Tests were inspected, not run.

_{Reviews (1) · Last reviewed commit: "fix(web): disable transcript editor duri..." · Reviewed by Greptile}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
cap-status	Skipped		Oct 29, 2026 5:23pm UTC

[greptile-apps]

Existing transcript test fails

The pending-save test in share-transcript-rendering.test.ts:299 calls editCue(3) while a save is pending. This change removes that row's edit button, so the helper throws Missing edit button before the test finishes. Update the test to expect editing to stay blocked, check that the textarea is disabled, and then resolve the save.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/web/app/s/[videoId]/_components/tabs/Transcript.tsx
Line: 824

Comment:
**Existing transcript test fails**

The pending-save test in `share-transcript-rendering.test.ts:299` calls `editCue(3)` while a save is pending. This change removes that row's edit button, so the helper throws `Missing edit button` before the test finishes. Update the test to expect editing to stay blocked, check that the textarea is disabled, and then resolve the save.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[ghazy2001]

Addressed in commit \2c33594b: updated test assertions in \share-transcript-rendering.test.ts\ to verify the active textarea is disabled, other cue edit buttons remain blocked (null) during pending saves, and then resolves the save cleanly.