Repository navigation
fix(web): send restricted custom-domain share pages to the main origin - #3543
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
richiemcilroy
marked this pull request as ready for review
October 29, 2026 13:09
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricted share pages opened on a verified custom domain now redirect to the same
/s/page on the main web origin, so a viewer's existing Cap session decides access.PolicyDeniedhandler checks the request host. On a verified custom domain it returns a redirect to the main origin instead of the denied state (apps/web/app/s/[videoId]/page.tsx:260,:468).resolveRestrictedShareRedirect(apps/web/lib/share-web-url.ts:100) reusesresolveShareWebUrl. The main origin returnsnullwithout a database lookup, so there is no redirect loop. Unknown or unverified hosts also returnnull. The video id is encoded as a single path segment, and every query parameter is preserved, including repeated keys.VerifyVideoPasswordError), which stay on the custom domainredirect()throws, so it runs after the Effect resolves. The denied branch returns a{ redirectTo }marker rather than throwing inside the Effect.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Restricted share pages on verified custom domains now send viewers to the main origin, where their existing session decides access.
No actionable issues were found.
Reviews (2) · Last reviewed commit: "fix(web): send restricted custom-domain ..." · Reviewed by Greptile