Repository navigation
Conversation
…twice Vitest's runner calls the file suite's beforeAll/afterAll itself around runner.runSuite(), on Vitest 3 and 4. The analysis runner called them again on the same root suite, so file-level setup ran twice: once outside the CodSpeed run and once inside it. Nested suites are only reached through the runner, so their hooks are still called, once each. Co-Authored-By: Claude Opus 5.5 <[email protected]>
 [Low impact] The PR appears safe to merge; no actionable issues were found. SummaryThe analysis runner now leaves the root suite’s
Reviews (1) · Last reviewed commit: "fix(vitest-plugin): stop calling the roo..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
Vitest's runner calls the file suite's
beforeAll/afterAllitself, aroundrunner.runSuite(), on both Vitest 3 and 4. The analysis runner called them again on the same root suite, so file-level setup ran twice: once outside the CodSpeed run and once inside it.runAnalysisBenchmarkSuitenow skips the hook calls for the root suite. Nested suites are only reached through this runner, so their hooks are still called, once each.Test
should leave the root suite's beforeAll/afterAll to vitestregisters both hooks on a root suite and a nested suite, then asserts that only the nested suite's hooks run, once each. It fails onmain(the root hooks show up) and passes with this change.lint,typecheck,formatand the plugin's 15 tests pass.🤖 Generated with Claude Code