Repository navigation
Conversation
When the benchmark file and the plugin resolve different copies of vitest (pnpm installs one per set of peers, e.g. one per vite major), the plugin reads an empty benchmark registry and the analysis runner failed with a bare "TypeError: fn is not a function". Throw an error that names the benchmark, the likely cause and the fix instead. Co-Authored-By: Claude Opus 5.5 <[email protected]>
[Low impact] The PR appears safe to merge. SummaryThe legacy Vitest analysis runner now explains why it cannot find a benchmark function instead of failing with
Reviews (1) · Last reviewed commit: "fix(vitest-plugin): explain a missing be..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.
When the benchmark file and the plugin resolve different copies of vitest (pnpm installs one per set of peers, e.g. one per vite major), the plugin reads an empty benchmark registry. The analysis runner then failed with a bare
TypeError: fn is not a function.runAnalysisBenchnow checks the result ofgetBenchFnand, when it isn't a function, throws an error that names the benchmark, the likely cause and the fix.This doesn't change which vitest the runner imports. That's the larger change discussed in the issue.
Test
should explain a benchmark function it cannot findmakesgetBenchFnreturnundefinedand asserts the new message. It fails onmainwithfn is not a function.lint,typecheck,formatand the plugin's 15 tests pass.🤖 Generated with Claude Code