[cs278]

Fixes #245

I figured performing an explicit cast would make the intention clearer than switching to an assertEquals constraint.

[cs278]

Not sure why the tests are failing, I cannot even see the failing test in the repository. 😕

[cs278]

@TavoNiievez any chance of input here?

[burned42]

Not sure why the tests are failing, I cannot even see the failing test in the repository. 😕

I did a bit of digging and found this patch file which seems to include the failing test, which gets applied in the github actions workflow only for the symfony 7.4 test suite, which explains why exactly/only that one is failing.

[cs278]

Yeah the patch is faulty asserting a charset attribute on non text responses:

https://github.com/Codeception/symfony-module-tests/blob/ba2692c634d8d956f9116cebca964db5087bf500/resetFormatsAfterRequest_issue_test.patch#L326-L331

[TavoNiievez]

@cs278 The solution you propose is correct.
The patch for version 7.4 is specific to a test on api-platform.
Currently, this repository is being tested through the symfony-module-tests project and through its own test suite in the tests/ folder.
My intention in creating the tests in this repository was to eventually stop relying on the tests in the symfony-module-tests project, but that work is still a work in progress.
The fact that this test is failing is an issue I need to fix, but it doesn’t prevent me from merging your contribution from this PR.
However, I must fix it before releasing a tag.
Thank you for your patience.

[cs278]

Thanks for the merge, I've actually worked around the issue in my project but I'll be able to remove that hack when you do publish a release. 😄