Skip to content

Remove Testspace setup and report generation steps - #886

Merged
Sergio0694 merged 1 commit into
mainfrom
user/sergiopedri/refresh-testspace-removal
Oct 26, 2026
Merged

Sergio0694 merged 1 commit into
mainfrom
user/sergiopedri/refresh-testspace-removal

Conversation

@Sergio0694

@Sergio0694 Sergio0694 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Fixes

Replaces the closed PR #881 by replaying its single original commit on latest main. No issue closure is requested.

Removed Testspace module installation and report creation steps from the CI workflow.

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

CI installs the external Testspace module using testspace-com/[email protected] and invokes testspace to publish test reports. These stale external steps need to be removed.

What is the new behavior?

Removes only the five-line Install Testspace Module step and the five-line Create test reports step from .github/workflows/build.yml (0 insertions, 10 deletions). Source-generator and component test execution, TRX logging, diagnostic artifact collection, and all other workflow settings remain unchanged. No tooling, SDK, or runner updates are included.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

The feature branch is in the upstream repository, not a fork. Creation requested maintainerCanModify: true, but GitHub reports maintainer_can_modify: false and rejects explicitly enabling it with HTTP 422: "Fork collab can only be enabled on cross-repo pull requests". This fork-only option does not apply to this same-repository PR; existing repository permissions govern branch edits. Component, sample, documentation, new-test, and source-header checklist items are not applicable to this workflow-only deletion.

Original commit: 12812d76260aefb1f89d8800b7474e953c21735f (1 commit). Replayed commit: 5b2df75f3acfb2697dc0c41fadc0844fb13e6494 (1 commit), preserving the original author, author date, and message. Base: 34a57f969bf7966e0a3cbe9d4d10a47758d097a0, verified against freshly fetched origin/main immediately before opening this PR. The original Sergio0694-patch-1 branch is unchanged.

Preservation validation (all passed):

  • git --no-pager diff --exit-code 12812d76260aefb1f89d8800b7474e953c21735f HEAD — exit 0; final trees are identical.
  • git --no-pager range-diff '12812d76260aefb1f89d8800b7474e953c21735f^!' 'HEAD^!' — exit 0; 1: 12812d7 = 1: 5b2df75.
  • git --no-pager rev-parse '12812d76260aefb1f89d8800b7474e953c21735f^{tree}' 'HEAD^{tree}' — exit 0; both trees are f4b1ca4ea2ddfe2d8e519429af45cc993ccb28d8.
  • git --no-pager diff --numstat origin/main HEAD — exit 0; only .github/workflows/build.yml, 0 insertions and 10 deletions.
  • git --no-pager diff --check origin/main HEAD — exit 0; no whitespace errors.

Binary patch validation used $artifacts pointing to the saved session-artifact directory:

git diff --binary --full-index --output="$artifacts\pr881-original.patch" '12812d76260aefb1f89d8800b7474e953c21735f^' 12812d76260aefb1f89d8800b7474e953c21735f
git diff --binary --full-index --output="$artifacts\pr881-replayed.patch" origin/main HEAD
git --no-pager diff --no-index --exit-code "$artifacts\pr881-original.patch" "$artifacts\pr881-replayed.patch"
Get-FileHash -Algorithm SHA256 -LiteralPath "$artifacts\pr881-original.patch", "$artifacts\pr881-replayed.patch"

All commands succeeded; patch comparison exited 0. Both patch files have SHA-256 402C521A3E8AA366292B2ABDC4FAD3D02F31DA5766030EBF7492B95D7ABA9472.

Builds and tests were not rerun locally: there are no source changes, and this replays the exact original workflow-only deletion. Repository build instructions and CI test commands were inspected; test execution and diagnostics remain unchanged. This validation does not claim CI has passed. This is a separate prerequisite PR to #885; that PR is untouched.

Removed Testspace module installation and report creation steps from the CI workflow.
@Sergio0694
Sergio0694 enabled auto-merge (squash) October 26, 2026 22:42
@Sergio0694
Sergio0694 merged commit 2556761 into main Oct 26, 2026
23 checks passed
@Sergio0694
Sergio0694 deleted the user/sergiopedri/refresh-testspace-removal branch October 27, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants