Repository navigation
feat: #184 support continuous SQL completion #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Cythia828
merged 1 commit into
DTStack:next
from
jin-sir:feat/continuous-sql-completion
Oct 30, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里用
hasFunctionContext判定具体补全项存在作用域混淆的问题。hasFunctionContext代表的是“当前光标位置语法上是否允许出现函数”。在 SQL 中,几乎所有核心表达式位置(如SELECT |投影列、WHERE |条件、ON |连接条件等)都允许函数调用,因此该标志在这些位置恒为true。如果直接用
item.insertText === undefined && isKeyword && hasFunctionContext判定,会导致在上述位置,所有普通关键字(例如DISTINCT、CASE、AND、OR等)都被判定为isParenFunction = true,从而全部丢失了尾随空格。更严重的是,下方的
advancesContext依然判定(item.insertText === undefined && isKeyword)为 true 并挂载了retriggerSuggestCommand,导致用户选中DISTINCT后插入无空格裸词并立即在原地重新触发建议框,建议框过滤出DISTINCT再次弹窗,导致无法通过回车/Tab 结束补全,陷入死循环。建议:
${name}($1))并标记为 snippet;advancesContext绝不能挂载retriggerSuggestCommand,避免原地重复触发。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个后续配合dt-sql-parser提取Function后再做