Repository navigation
Migrate internal-api groovy files to java part 8 - #13054
Conversation
we migrate 11 tests: - ConfigInversionMetricCollectorImplTest - CoreMetricCollectorBaggageTest - CoreMetricCollectorTest - EndpointCollectorTest - IntegrationsCollectorTest - MetricCollectorTest - OtelEnvMetricCollectorImplTest - ProductChangeCollectorTest - ProductChangeTest - WafMetricCollectorTest - JDK9StackWalkerTest Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The migrated tests preserve the original cases and assertions, with singleton cleanup and ordering adjustments for JUnit. No human PR discussion raised additional concerns.
🤖 Bits Code Review · Commit a993e6b
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
we migrate 11 tests:
Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
part1: #12663
part2: #12766
part3: #12826
part4: #12839
part5: #12866
part6: #12916
part7: #12952
Additional Notes
No production code change. Groovy tests accessed private members that Java tests cannot reach, so:
IntegrationsCollectorTestandProductChangeCollectorTestfill the collector through the publicupdate()method instead of the private queueConfigInversionMetricCollectorImplTestasserts the metric name literal instead of the privateCONFIG_INVERSION_METRIC_NAMEconstantConfigInversionMetricCollectorTestHelpermoved from the groovy to the java test source setSpock runs feature methods in declaration order, JUnit does not, and these collectors are singletons:
CoreMetricCollectorTestandWafMetricCollectorTestflush pending metrics in a@BeforeEachWafMetricCollectorTestruns the framework cardinality cap test last (@Order), as the per-framework counters are never evictedContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
🤖 Generated with Claude Code