Repository navigation
Grids: remove editing hacks and type cross-extender overrides - #35932
Open
anna-shakhova wants to merge 8 commits into
Open
anna-shakhova wants to merge 8 commits into
anna-shakhova wants to merge 8 commits into
Conversation
Alyar666
requested changes
Oct 27, 2026
| } | ||
| } | ||
|
|
||
| export interface EditingRowsViewExtension { |
Contributor
There was a problem hiding this comment.
We usually move types and interfaces to types.ts.
| * @returns whether to cancel cell editing | ||
| */ | ||
| protected _beforeEditCell( | ||
| public _beforeEditCell( |
Contributor
There was a problem hiding this comment.
Would it be too costly for us to remove the _ prefix from the public method?
…ell to beforeEditCell
Alyar666
previously approved these changes
Oct 27, 2026
Alyar666
approved these changes
Oct 27, 2026
anna-shakhova
enabled auto-merge
October 27, 2026 11:10
auto-merge was automatically disabled
October 27, 2026 13:18
Pull request was closed
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_rowClickTreeListHackand_rowDblClickTreeListHackare removed from the core editing rows-view extender. The editing part of a row click / double-click now lives in two overridable methods on EditingRowsViewExtension:handleRowClickByEditingandhandleRowDblClickByEditing._rowClick / _rowDblClickkeep only the select-checkbox guard. This removesvalidateClick,needToCallOriginalClickHandler, the event-type switch and two @ts-expect-error.isCellBasedEditMode,isRowBasedEditModeandisFormBasedEditMode. Single-mode checks are written asgetEditMode() === EDIT_MODE.x.getEditMode()._beforeEditCellis now in CellBasedEditingControllerExtension and is public, because an interface can't hold a protected member. Validating's_beforeEditCellis public override with item_getValidationGroupsInFormunder @ts-expect-error. Validating now overrides the typedgetEditFormOptionsand adds validationGroup to its result. Call order and result are unchanged.