Repository navigation
fix(arc): check orgs per cluster and refuse a scale set registered from two clusters - #136
Conversation
…om two clusters The cross-host checks compared every host in the inventory, so an org whose scale sets were split between two clusters was refused as a duplicate. They now compare the hosts of this host's cluster group, which share a controller, and compare other clusters' hosts only for the scale set names GitHub gives to one controller at a time. A host outside its cluster group still counts the whole inventory as one cluster. Fixes #130
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6851ba75a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…le says The cross-cluster check compares scale sets by release name, which is the scale set's registration identity only while the chart's runnerScaleSetName defaults to it. A values file setting its own name broke that, so the name is now passed with --set alongside the other values the role owns.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.7.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
The ARC validation compared
github_runner_arc_orgsacross every host in the inventory, so with two clusters in one inventory an org whose scale sets sit partly on each cluster's installer host was refused as configured twice.The cross-host checks now run over the hosts of this host's cluster group (
github_runner_cluster_group), which share one controller, its namespaces and the autoscaled pool. Within a cluster an org is still installed from one host, and the message names both hosts. Hosts of another cluster may install the same org, and are compared only for scale set names: the same org and release name registered from two clusters is refused, naming both profiles and hosts, since GitHub gives a scale set name to one controller at a time. A host that is not in its cluster group (the control node runningplaybooks/arc.yml, or an implicit localhost) cannot tell which hosts share its cluster, so it keeps the old behaviour and counts the whole inventory as one cluster.The new
arc_cluster_profilesfilter does the grouping and the cross-cluster comparison and hands the cluster's orgs toarc_profiles. Tests cover the filter directly and the real validation tasks with a two-group inventory. The ARC README's line that only one profile in the inventory may be autoscaled was also wrong (several may be, with at most one settingsizing), and now says so per cluster.Fixes #130