Repository navigation
Retry parameter writes when the CRSF output slot is busy - #50
Merged
Merged
Conversation
Test build for 8ec300e
|
CapnBry
approved these changes
Oct 28, 2026
CapnBry
left a comment
Member
There was a problem hiding this comment.
Ah yup, I saw this as well once and didn't look into it because it never happened again and I thought it was just me pushing the wrong button. This is the right way to manage it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on a real radio: changing RF Band right after the main page loaded, while the inner menus were still loading in the background, snapped it back to 868MHz.
crossfireTelemetryPush() returns false while the previous frame is still waiting to go out.
Writes ignored that, so a write made while fields were loading in the background
could be dropped. The tool then re-read the old value.
Writes now try once and go into the queue if the slot is busy; tick() only takes a
write off the queue once the push succeeds. The CRSF simulator mock now accepts only
one push per tick, like EdgeTX.