Skip to content

feat(Flag Dependency): Evaluate flags that depend on other flags - #267

Merged
emyller merged 7 commits into
mainfrom
linear/sdk-2-enable-flag-dependency-in-all-server-side-sdks-85ed
Oct 30, 2026
Merged

emyller merged 7 commits into
mainfrom
linear/sdk-2-enable-flag-dependency-in-all-server-side-sdks-85ed

Conversation

@linear-code

@linear-code linear-code Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Local evaluation ignores segments that depend on other flags ($.flags.<feature>.enabled), unlike flagsmith-engine and the Flagsmith API.

Closes SDK-2. Tested by engine-test-data v3.12.1 and sdk-spec v0.7.0.

Changes

  • Identity flags now follow the flags they depend on, including chains; cycles report ERROR; code=CIRCULAR_DEPENDENCY.
  • Environment flags now get segment overrides that only read $.environment or $.flags; segments needing an identity are still left out.
  • CI runs engine-test-data v3.12.1 and sdk-spec v0.7.0.

🤖 Generated with Claude Code

…ocal evaluation

Identity flags in local evaluation are resolved lazily against a context
trimmed to the requested feature, which hides the flags a segment
condition such as `$.flags.<feature>.enabled` depends on. Features
overridden by such segments are now resolved against the full context.

Contributes to https://linear.app/flagsmith/issue/SDK-2/enable-flag-dependency-in-all-server-side-sdks

Generated with [Linear](https://linear.app/flagsmith/agent-session/c423fe72-0914-42ca-8401-f6992464b081)

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
@linear-code
linear-code Bot requested a review from a team as a code owner October 21, 2026 16:33
@linear-code
linear-code Bot requested review from khvn26 and removed request for a team October 21, 2026 16:33
emyller and others added 4 commits October 21, 2026 16:53
… lazy flags

Generated with [Linear](https://linear.app/flagsmith/agent-session/c423fe72-0914-42ca-8401-f6992464b081)

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
…lag-dependency-in-all-server-side-sdks-85ed

# Conflicts:
#	.gitmodules
…ronment flags

Environment flags keep segments that only read `$.environment` or `$.flags`, as the Flagsmith API does, and still leave out segments needing an identity. Runs sdk-spec v0.7.0, which covers environment-level flag dependency.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…ncy cases

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@emyller emyller changed the title feat(Flag Dependency): Evaluate flags that depend on other flags in local evaluation feat(Flag Dependency): Evaluate flags that depend on other flags Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 18e896eb-98fd-482a-ae0d-87184685a9bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks


Comparing linear/sdk-2-enable-flag-dependency-in-all-server-side-sdks-85ed (22d07fa) with main (4d5c27f)

Open in CodSpeed

…lag-dependency-in-all-server-side-sdks-85ed

# Conflicts:
#	.github/workflows/codspeed.yml
@emyller emyller self-assigned this Oct 30, 2026
@emyller
emyller merged commit ab669bb into main Oct 30, 2026
9 checks passed
@emyller
emyller deleted the linear/sdk-2-enable-flag-dependency-in-all-server-side-sdks-85ed branch October 30, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants