Repository navigation
Conversation
…ocal evaluation Identity flags in local evaluation are resolved lazily against a context trimmed to the requested feature, which hides the flags a segment condition such as `$.flags.<feature>.enabled` depends on. Features overridden by such segments are now resolved against the full context. Contributes to https://linear.app/flagsmith/issue/SDK-2/enable-flag-dependency-in-all-server-side-sdks Generated with [Linear](https://linear.app/flagsmith/agent-session/c423fe72-0914-42ca-8401-f6992464b081) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
… lazy flags Generated with [Linear](https://linear.app/flagsmith/agent-session/c423fe72-0914-42ca-8401-f6992464b081) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
…lag-dependency-in-all-server-side-sdks-85ed # Conflicts: # .gitmodules
…ronment flags Environment flags keep segments that only read `$.environment` or `$.flags`, as the Flagsmith API does, and still leave out segments needing an identity. Runs sdk-spec v0.7.0, which covers environment-level flag dependency. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…ncy cases Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…lag-dependency-in-all-server-side-sdks-85ed # Conflicts: # .github/workflows/codspeed.yml
khvn26
approved these changes
Oct 30, 2026
emyller
deleted the
linear/sdk-2-enable-flag-dependency-in-all-server-side-sdks-85ed
branch
October 30, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local evaluation ignores segments that depend on other flags (
$.flags.<feature>.enabled), unlike flagsmith-engine and the Flagsmith API.Closes SDK-2. Tested by engine-test-data v3.12.1 and sdk-spec v0.7.0.
Changes
ERROR; code=CIRCULAR_DEPENDENCY.$.environmentor$.flags; segments needing an identity are still left out.🤖 Generated with Claude Code