Repository navigation
feat: add a speed option for spacebar cursor control - #516
Closed
SebastianK1999 wants to merge 1 commit into
Closed
SebastianK1999 wants to merge 1 commit into
SebastianK1999 wants to merge 1 commit into
Conversation
Spacebar cursor control is now driven by finger movement instead of the long press: the press origin comes from the ACTION_DOWN x, the platform touch slop decides that the finger is swiping (cancelling the pending language dialog), and the configured step decides how much travel one character needs. Previously the first movement event only seeded the origin and any later event more than a fixed 8dp away moved the cursor. Adds one setting under Typing and input, "Cursor movement speed": Slow (24dp), Normal (16dp, default) and Fast (8dp), where Fast reproduces the previous behaviour. Cursor movement now buzzes with KEYBOARD_TAP like the rest of the keyboard, instead of TEXT_HANDLE_MOVE, which produces no vibration on some devices. Refs FossifyOrg#377
Contributor
|
Fossify accepts code contributions only for open issues labeled |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I'm just user of Your app.
I would like to say i love it. I love how simple and easy to use it is. But i had just one small problem, so i woukd love to share it with you, and hopefully give something from me to improve experience to everyone.
There is a feature, where you can swipe on spacebar to move carret. i feel like all keboards have it wrong, so i decided to fix it. The problem with is that it gives no feedbak to the user when he scrolls and the movement is WAY TOO FAST. it is imposible to land exactly where you want. I thnik, it should be used for precise carret movements. So i gave an option to slow it down and hapric "clicks" when carret moves. i was testing it for a while now on my phone. And i can confirm It really works well and it is nice and easy to navigate.
I am aware you wont be taking my solutions blindly. And that is perfectly ok. It needs testing on your side. and review or maybe even rewrite. My goal here is to give you an idea on what might be worth adding.
Im not doing to lie. i used AI to add this feature. Im not an android developer (but i am a developer). Also, the solution is missing Translations. And Tests [if there are any]. And possibly something else. But to my eye it looks reasonable as a feature and code change. Hope my suggestion turns out useful.