Repository navigation
fix: channel list footer flicker on pagination - #3911
Merged
isekovanic merged 1 commit intoOct 30, 2026
Merged
isekovanic merged 1 commit into
isekovanic merged 1 commit into
Conversation
isekovanic
force-pushed
the
fix/channel-list-loading-spinner-flicker
branch
from
October 30, 2026 12:34
e50f5dd to
7883185
Compare
oliverlaz
approved these changes
Oct 30, 2026
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/stream/issue/REACT-1476/fix-odd-edge-cases-for-channel-list-recovery
π― Goal
Scrolling down the channel list made the footer loading indicator flicker in and out, and often it was not visible at all while the next page loaded. On V9 it showed for the whole load.
Stacked on #3910.
π Implementation details
The footer shows while
activeQueryTypeis'loadChannels'and the paginator is loading.queryChannelssetsactiveQueryTypeback tonullonce itstoTail()returns. While a page is loading, the paginator refuses anothertoTail(), which returns right away. So a secondloadNextPagecleared the flag of the page still in flight.FlatList calls
onEndReachedagain whenever the content length changes, and showing or hiding the footer changes it. So each page went through a loop: the footer mounts, a refused call hides it, the footer comes back briefly, and it stays hidden for the rest of the load.queryChannelsnow returns early while the paginator is loading, so a query the paginator would refuse never touchesactiveQueryType. This also keeps a refused call from clearing therefreshingstate of a pull-to-refresh in flight.π¨ UI Changes
The footer loading indicator shows once per next page, for the whole load.
π§ͺ Testing
ChannelListtest: callingloadNextPageagain while a next page loads keeps the footer indicator, and it hides once the page lands. It fails without the fix.ChannelListandChannelPreviewtests,yarn test:typecheck, eslint and prettier pass.βοΈ Checklist
developbranch