Repository navigation
fix(deps): bump @stream-io toolkit packages to the .mjs/.cjs builds - #3915
Merged
Merged
Conversation
The js-toolkit packages now ship explicit .mjs/.cjs builds (ES2022), so their ESM entry loads as ESM on Node without syntax detection. Before, Next.js SSR crashed loading stream-chat-react with "does not provide an export named StateStore" on such runtimes. Bump the ranges, dedupe each toolkit package to one version, and preapprove the toolkit packages in .yarnrc.yml so the npmMinimalAgeGate does not hold back first-party releases (as stream-chat already is).
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the js-toolkit releases that ship explicit
.mjs/.cjsbuilds targeting ES2022 (GetStream/js-toolkit#58). Their previous ESM build was.jsin packages without"type", which Node only loaded as ESM through syntax detection.package/:@stream-io/i18n^1.0.2→^1.1.0,@stream-io/state-store^1.1.6→^1.2.0; SampleApp: state-store^1.2.0stream-chat's^1.1.6resolves to state-store 1.2.0; transitive@stream-io/logger2.1.0).yarnrc.yml: preapprove the js-toolkit packages next tostream-chat, sonpmMinimalAgeGate(3d) doesn't hold back first-party releasesMetro (0.80+) indexes
.cjs/.mjsby default (watcher.additionalExts), and the stream-video RN dogfood app bundles with these builds.Verified in a clean worktree:
yarn install --immutable,yarn build,yarn lint,yarn typecheckpass.yarn test:coverage: 2333/2335; the two failures (ChannelPreviewmark_read,ownCapabilitiessend-reply) pass when run on their own, with and without this change.🎫 Ticket: https://linear.app/stream/issue/REACT-1474