Repository navigation
DEV-4505: Build gravitykit.dev on Node 24 and stop the Node 20 deprecation warnings - #26
Merged
zackkatz merged 1 commit intoNov 1, 2026
Conversation
GitHub deprecated the Node 20 runtime that checkout@v4, setup-node@v4, upload-pages-artifact@v3 and deploy-pages@v4 use, and every deploy warned about it. Build on Node 24 and move each action to its Node 24 major. Node 22+ treats `node --test scripts/lib/` as a module path and fails, so npm test now passes a file pattern that works on Node 20 and 24. Fixes DEV-4505.
|
Caution Review failedThe pull request is closed.
|
zackkatz
deleted the
feature/dev-4505-gravitykitdev-move-ci-to-node-24-before-github-drops-node-20
branch
November 1, 2026 02:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every gravitykit.dev deploy warns that its actions run on Node 20, which GitHub has deprecated and now forces onto Node 24. This moves the build to Node 24 and each action to its Node 24 major, so the warnings stop and the deploy keeps working once Node 20 is removed.
Fixes DEV-4505
What changed and why
deploy.ymlandtoken-interop.yml:node-version20 to 24,actions/checkoutv4 to v7,actions/setup-nodev4 to v7.deploy.yml:actions/upload-pages-artifactv3 to v5 andactions/deploy-pagesv4 to v5. Since v4, the upload action leaves out dotfiles by default. The build output has none, so nothing is lost.package.json:npm testnow runsnode --test scripts/lib/*.test.mjs. Node 22+ treats a bare folder after--testas a module path and fails withCannot find module, which would have broken the token-interop workflow on Node 24. The shell expands the pattern, so it also works on Node 20.AGENTS.md: the test command line matches.Tested locally on Node 24.13.0 with PHP 8.3, the same steps CI runs:
npm ci, thennpm test: 59/59 pass. Also 59/59 on Node 20.20.0.npm run docs:generate,npm run llm:enhance,npm run build: build succeeds.npm run tokens:verify: 245 of 245 records reproduce GravityView's CSS.The token-interop workflow runs on this PR with the new actions.
Blast radius
Release: none (docs-site CI; nothing ships to customers)
This was 🤖 Generated