Repository navigation
feat(input): improve autofill - #17840
Merged
Merged
Conversation
adrianptrv
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Autofilled inputs bypass the disabled text color because the shared disabled-state rules do not update the new custom property.
1 open issue
What changed in this PR
This PR addresses #17595 by adjusting Input Group autofill styling so browser backgrounds do not obscure floating labels in border mode.
Changes:
- Clips autofill backgrounds to text and explicitly sets the autofilled text color.
- Uses a shared custom property for default, hover, and focused text colors.
| File | Description |
|---|---|
| projects/igniteui-angular/input-group/src/input-group/themes/_base.scss | Adds autofill styling and centralizes input text-color state handling. |
Review effort: Balanced
simeonoff
approved these changes
Oct 28, 2026
Member
There was a problem hiding this comment.
Nice work on this one, thanks! Moving the text color into a single variable that every state updates keeps the autofilled text matching the theme on hover, focus, readonly and disabled, and background-clip: text fixes the label overlap without touching the rest of the input. It's also good to have this match the web components fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17595
Description
Same changes as in: IgniteUI/igniteui-webcomponents#2298
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Input Group
How Has This Been Tested?
Checklist: