Repository navigation
Conversation
Open
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 46.91% 46.73% -0.19%
==========================================
Files 20 20
Lines 2498 2508 +10
==========================================
Hits 1172 1172
- Misses 1326 1336 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
blegat
force-pushed
the
inbounds-decompression
branch
from
October 22, 2026 13:32
6ad8f5e to
904c203
Compare
gdalle
requested changes
Oct 26, 2026
gdalle
left a comment
Member
There was a problem hiding this comment.
We've had this discussion with @amontoison in the past and I'm very uncomfortable adding @inbounds to a loop without previously checking that all indexing falls in the proper range. However I think this could be an opportunity to tighten our typing, and maybe put Vectors everywhere we can, to simplify this kind of verification (there are lots of places where AbstractVectors are accepted but really shouldn't be).
blegat
force-pushed
the
inbounds-decompression
branch
from
October 28, 2026 08:54
544fe40 to
984adab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs this one to be merged first, I'll rebase afterwards (so at the moment the diff contains both):
Add
@inboundsto the CSC recovery loops and propagate it through the shared write helper withBase.@propagate_inbounds.Fresh median timings for the same benchmark as #354:
On Julia 1.13.1 with Intel i7-12700K.