Repository navigation
Update playwright - #1068
Merged
Merged
Update playwright#1068
Conversation
added 2 commits
October 30, 2026 10:31
Update release notes to latest Get rid of slop from instructions to the best of my ability Update nvm version -> 22 Update package-lock.json Fix floating-point precision in context menu tests Replace exact equality (.toEqual) with approximate comparison (.toBeCloseTo) for floating-point coordinate values. This resolves intermittent test failures caused by tiny precision differences that arise from: - Node.js version changes affecting V8 optimizations - Different floating-point rounding in coordinate transformations - Dependency version updates Using toBeCloseTo with 6 decimal places (±0.0000005) provides meaningful validation while tolerating expected numerical variance. This pattern is already used in other coordinate comparison tests like axisInferring.test.js. Fixes: Coordinate precision errors in 'Context menu, back item' and 'Context menu, forward item' tests. Upgrade playwright (and consequently chromium). Fix / update broken tests mostly due to changes in last digits of coordinates returned by browser, and a few flakes de-flake long standing flaky tests
…rs at npm >=12.0.0 when installing dependencies from git repos i.e. "$ npm install npm error code EALLOWGIT npm error Fetching packages of type "git" have been disabled npm error Refusing to fetch "proj4leaflet@git+ssh..."
prushforth
force-pushed
the
update-playwright
branch
from
October 30, 2026 14:31
d9fea4f to
4d11233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.