Skip to content

Fix folder drawer opening and white transitions in dark mode - #56

Merged
MaxDac merged 1 commit into
mainfrom
fix/drawer-and-dark-transitions
Oct 27, 2026
Merged

MaxDac merged 1 commit into
mainfrom
fix/drawer-and-dark-transitions

Conversation

@MaxDac

@MaxDac MaxDac commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • The folder drawer drew an empty sheet while closed and swapped in the folder tree as it opened, so opening looked jumpy. It now keeps one stable sheet and only hides it from semantics while closed.
  • The window and the navigation host had no dark background, so screen transitions flashed white in dark mode. The navigation host now has an opaque themed background, the window background follows the resolved theme, and a values-night theme covers the cold start.

All changes are in :app-shared, so MarkNotes Plus gets them by bumping its libre/ submodule (no API change).

Parity impact

  • None: Android-only change
  • Shared behaviour
  • Desktop/web follow-ups
  • Shared sync API/package/Pro impact: none; Pro picks this up through the submodule bump

Checklist

  • ktlintCheck detekt pass locally; assembleDebug builds
  • UI tested on Waydroid in dark mode (drawer, Settings transition). Animation frames could not be captured; the original bug recordings were not viewable here.
  • CI checks (running)

🤖 Generated with Claude Code

The closed drawer drew an empty sheet and swapped in the folder tree while
opening; it now keeps one stable sheet and only hides it from semantics when
closed. The window and the navigation host had no dark background, so screen
transitions showed white; they now follow the app theme, and a values-night
theme covers the cold start.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@MaxDac
MaxDac enabled auto-merge (squash) October 27, 2026 10:33
@MaxDac
MaxDac merged commit 8af2d94 into main Oct 27, 2026
14 checks passed
@MaxDac
MaxDac deleted the fix/drawer-and-dark-transitions branch October 27, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant