Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
# Conflicts: # packages/social-controllers/CHANGELOG.md
zone-live
approved these changes
Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Social-api is adding a new position flag,
unsupported-token(va-mmcx-social-api#494). It marks a position on a token that is excluded from PnL for every trader (trading_metrics.blocked_tokens). The position is still returned but does not count toward the trader's realized PnL. A position can carry it alongsideinsider, soflagsmay be['insider', 'unsupported-token'].Position.flagswas added in #11097 as an open list of strings, soSocialServiceand realtime feed hydration already accept and keep this value. No validation change is needed. This PR addsUNSUPPORTED_TOKEN_POSITION_FLAGas a named constant besideINSIDER_POSITION_FLAGandDEVELOPER_POSITION_FLAG, exports it from the package, and documents its meaning onPosition.flags.Unlike
insider, social-api does not say thatunsupported-tokenpositions must not be copy-traded, so the docs only describe the PnL exclusion.This is additive. There are no changes to existing types or validation.
References
Position.flagsChecklist
Note
Low Risk
Additive constant, documentation, and tests only; no runtime or validation behavior changes.
Overview
Adds
UNSUPPORTED_TOKEN_POSITION_FLAG(unsupported-token) as a named, exported constant alongside the existing insider and developer position flags, matching a new social-api flag for tokens excluded from every trader's realized PnL (positions still appear in responses but do not count toward PnL; can combine withinsider).JSDoc on the constant and on
Position.flagsis updated to describe this behavior (PnL exclusion only—no copy-trade restriction). The changelog records the addition. Tests assert the package export and thatfetchOpenPositionsstill passes throughunsupported-tokenin the openflagslist (no validation or schema changes).Reviewed by Cursor Bugbot for commit d54903b. Bugbot is set up for automated code reviews on this repo. Configure here.