Skip to content

Error pages for vaccination history and PDS API problems - #906

Merged
Anna-Sutton merged 14 commits into
mainfrom
vax-history-error-pages
Oct 27, 2026
Merged

Error pages for vaccination history and PDS API problems#906
Anna-Sutton merged 14 commits into
mainfrom
vax-history-error-pages

Conversation

@Anna-Sutton

@Anna-Sutton Anna-Sutton commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Amended existing vax history error page to remove 'Continue anyway' button. Discussed with devs and decided if no history at all can be fetched from the APIs, we'd allow the user 1 go at calling the APIs again with a 'Try again button'.
  • Added extra error page with 'Continue anyway' button for when no vax history could be retrieved after the user has had their 1 go to try again (see scenario above).
  • Updated the PDS API error for when user has tried again and now only has option to continue, to reflect wording that is being developed.
  • Updated prototype index page to add the new error page and reflect the other changes.

@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:20 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:21 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:29 Inactive
@Anna-Sutton Anna-Sutton changed the title Add error page for vaccination history retrieval failure Add error page for vaccination history API problem Oct 19, 2026
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:30 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:41 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 10:45 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 11:04 Inactive
@frankieroberto
frankieroberto temporarily deployed to record-a-vac-vax-histor-7j9vgg October 19, 2026 11:09 Inactive
@Anna-Sutton Anna-Sutton changed the title Add error page for vaccination history API problem Error pages for vaccination history and PDS API problems Oct 23, 2026
@Anna-Sutton

Anna-Sutton commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@benjystanton could you review this PR please. No major rush.

benjystanton
benjystanton reviewed Oct 27, 2026
View reviewed changes
Comment thread app/views/errors/pds-error-continue-anyway.html
benjystanton
benjystanton approved these changes Oct 27, 2026
View reviewed changes

@benjystanton benjystanton left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anna-Sutton

Looks good to me, ready to merge.

I've made one suggestion, but it's not critical.

I've also done a little bit of tidying up whitespace and indentation (just to make it easier for me to read)

@Anna-Sutton

Anna-Sutton commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @benjystanton for reviewing and tidying up. I've applied your suggestion.

@Anna-Sutton
Anna-Sutton marked this pull request as ready for review October 27, 2026 09:14
@Anna-Sutton
Anna-Sutton merged commit 60849ea into main Oct 27, 2026
1 check passed
@Anna-Sutton
Anna-Sutton deleted the vax-history-error-pages branch October 27, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjystanton benjystanton benjystanton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anna-Sutton @benjystanton @frankieroberto