Skip to content

Polish audio TN - #470

Draft
jimregan wants to merge 57 commits into
NVIDIA:mainfrom
jimregan:polish-tn
Draft

jimregan wants to merge 57 commits into
NVIDIA:mainfrom
jimregan:polish-tn

Conversation

@jimregan

@jimregan jimregan commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do ?

Audio TN for Polish. Also TN, but that has too many non-determinisms to care about

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

@jimregan
jimregan marked this pull request as draft August 7, 2026 23:09
jimregan and others added 22 commits August 8, 2026 08:52
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
Signed-off-by: Jim O'Regan <[email protected]>
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Aug 31, 2026
Note that Google Translate's TTS can manage 0,00000000000000001 ("zero i jedna stubiliardowa") but higher than that it becomes stupid: 0,000000000000000001 comes out as "zero jeden przez zero...(18 times)" ("zero one divided by zero zero etc.")

Signed-off-by: Jim O'Regan <[email protected]>
@github-actions github-actions Bot removed the Stale label Sep 2, 2026
@tbartley94 tbartley94 self-assigned this Sep 11, 2026
@jimregan

Copy link
Copy Markdown
Contributor Author

Hmm... I thought github knew to sign

Signed-off-by: Jim O'Regan <[email protected]>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Oct 7, 2026
@tbartley94

Copy link
Copy Markdown
Member

@jimregan you ready to move this out of draft?

@github-actions github-actions Bot removed the Stale label Oct 8, 2026
@jimregan

jimregan commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Probably; I think most of what I intended to do is done. I'll try to get to it soon

@tbartley94

Copy link
Copy Markdown
Member

Probably; I think most of what I intended to do is done. I'll try to get to it soon

sgtm, just needed to check since i hold off on technical review until out of draft from. take your time.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Oct 23, 2026
@github-actions github-actions Bot removed the Stale label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants