Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quote PostgreSQL and MongoDB usernames, passwords and database names in the six Helm ConfigMaps that supply database configuration. Kubernetes requires ConfigMap data values to be strings: a password such as "123456" currently renders as a number, "null" renders as null, whitespace can be lost, and multiline values can break template parsing. Quoting preserves the configured value in both database and application ConfigMaps.
Refs #324 and the earlier, closed/unmerged #349. This PR covers database configuration values specifically, rather than claiming to resolve every Helm deployment issue. It bumps the chart version to 0.1.6 and adds rendered-manifest regression tests plus a dedicated CI job.
Testing
On Windows with Python 3.10 and Helm 3.16.4:
python -m pytest deploy/tests -q: 7 passed. The six custom-credential cases failed before the fix; the default configuration passed.helm lint deploy/helm: passed; only the existing optional chart-icon recommendation appears.git diff --check: passed.The branch was tested independently from the chatbot fix. No live Kubernetes deployment or database login was performed. The new CI job runs chart rendering tests and Helm lint without a cluster.
Documentation
Added test setup and execution instructions in
deploy/tests/README.md.Checklist: