Skip to content

Align startup check with actual migrations table name - #6066

Merged
rbev merged 1 commit into
masterfrom
schema-check
Oct 30, 2026
Merged

rbev merged 1 commit into
masterfrom
schema-check

Conversation

@rbev

@rbev rbev commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the way the system identifies the primary instance's migrations history table, ensuring consistency between the codebase and tests. The main change is renaming the primary migrations history table from __EFMigrationsHistory to __ErrorMigrationsHistory throughout the code and tests.

Migrations history table renaming:

  • Changed the constant PrimaryMigrationsHistoryTableName in AuditDbContext from __EFMigrationsHistory to __ErrorMigrationsHistory to align with ServiceControlDbContext.MigrationsHistoryTableName.
  • Updated test setup in SchemaSetupTests to use __ErrorMigrationsHistory instead of __EFMigrationsHistory when creating tables and asserting error messages, ensuring tests reflect the new table name. [1] [2]

@johnsimons johnsimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@rbev
rbev merged commit cecc5ad into master Oct 30, 2026
36 checks passed
@rbev
rbev deleted the schema-check branch October 30, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants