Skip to content

fix(diagnostics): fillet, chamfer and ql failures carry their picture again - #66

Open
NiJingzhe wants to merge 1 commit into
devfrom
fix/restore-deleted-tests
Open

NiJingzhe wants to merge 1 commit into
devfrom
fix/restore-deleted-tests

Conversation

@NiJingzhe

Copy link
Copy Markdown
Collaborator

2.2.7b1 drew a failure picture for booleans only; fillet, chamfer and ql cardinality errors lost theirs in the port (the original tests that assert them were deleted with the engine commit).

  • Blend diagnoses name the edges to mark; the operator requests the render (same captions, same dedup as 2.2.6).
  • The ql evidence provider is registered (the C++ hook existed, nothing installed it): matched faces orange, near misses purple, legend and callouts.
  • Highlighted faces use the standard material, as the VTK path did; sampled colours on the matched faces equal the 2.2.6 image.
  • Restores test_error_diagnostics_blend_ql.py and test_rearchitecture_2_0_kernel_builders.py unchanged.

Tests: test + tests 2128 passed; src/cpp/tests/python 468 passed. Seven more deleted test files (tracked_* / units / graph ql ...) are still to be restored in follow-up PRs.

🤖 Generated with Claude Code

… again

2.2.7b1 requested a failure picture for booleans only. The blend diagnoses now name the edges to mark and the
operator asks for the render; the ql evidence provider (the C++ hook existed, nothing registered it) renders the
scope with matched faces orange and near misses purple. Highlighted faces use the standard material as the VTK path did.
Restores test_error_diagnostics_blend_ql.py and test_rearchitecture_2_0_kernel_builders.py, deleted when the engine was ported.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant