Repository navigation
Fix _ftp_parse._parse_time for Python ≥ 3.15 - #606
Open
markmentovai wants to merge 1 commit into
Open
markmentovai wants to merge 1 commit into
markmentovai wants to merge 1 commit into
Conversation
time.strptime processing of formats that contain %d but not %Y was deprecated in Python 3.13, and removed from Python 3.15 (python/cpython#70647). Deal with this by adding %Y and having it parse the current year, in line with prior semantics. This fixes these tests/test_ftp_parse.py TestFTPParse tests by restoring the ability to parse the '%b %d %H:%M' time format. - test_decode_linux - test_decode_linux_sticky - test_decode_linux_suid - test_parse_time
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
time.strptimeprocessing of formats that contain%dbut not%Ywas deprecated in Python 3.13, and removed from Python 3.15 (python/cpython#70647). Deal with this by adding%Yand having it parse the current year, in line with prior semantics.This fixes these
tests/test_ftp_parse.py TestFTPParsetests by restoring the ability to parse the'%b %d %H:%M'time format.test_decode_linuxtest_decode_linux_stickytest_decode_linux_suidtest_parse_time