Repository navigation
Ignore empty abbreviation definitions in element tails - #1677
Merged
waylan merged 2 commits intoOct 26, 2026
Merged
Conversation
Apply the same nonempty-definition check used for element text to tails. Cover empty and nonempty glossary entries around inline elements and record the behavior in the unreleased changelog. Assisted-by: OpenAI GPT-6 <[email protected]>
Member
|
You have some unmet requirements according to the unchecked items. If you can't be bothered to follow our guidelines, then why should we be bothered to review your submission? |
Contributor
Author
|
Thanks for pointing this out. I’ve reviewed the changes and corrected the checklist. The changelog merge conflict is also resolved |
waylan
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An empty glossary definition is already ignored when an abbreviation occurs
in an element's text. After an inline element, the same abbreviation is
incorrectly wrapped in an empty-title
<abbr>element.For example:
Actual output:
Expected output:
Apply the existing nonempty-definition check to element tails as well. Add a
regression with empty and nonempty glossary definitions before and after an
emphasis element, and an unreleased changelog entry.
The new regression failed before the fix. All 31 abbreviation tests pass
afterward.
python -m unittest discover testsreports 1,138 tests run, OK,with 52 skipped on Windows / CPython 3.14.0. Optional Pygments and Tidy
dependencies were not installed. Changed-file Flake8 passes. Full Flake8
reports four unchanged E201/E202 findings in
postprocessors.py:90, alsoreproduced from the base source.
AI Assistance Disclosure
No AI tools were used in preparing this PR.
AI tools were used and I have disclosed which ones, and have fully reviewed and verified their output.
OpenAI Codex generated the proposed fix, regression test, changelog entry,
proposed commit message and this draft description. The submitter must
personally review and
understand the changes before checking the declaration above.
AI tools were used to assist with the following:
Checklist