Repository navigation
Conversation
The publish job ran on Python 3.10, whose bundled pip still trusts the compromised eMudhra/emSign root. Build and upload on Python 3.13, whose latest patch bundles pip 26.2.2+, and fail the job if pip is older. Signed-off-by: mday-io <[email protected]>
mday-io
force-pushed
the
claude/sqlmesh-security-review-hignxb
branch
from
October 23, 2026 05:06
64a6bc0 to
3ea4856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens the release
publishjob in response to the eMudhra / emSign CA certificate incident (see the PSF's "Information for Python users regarding eMudhra / emSign CA certificate security incident" post on discuss.python.org). The compromised root was removed incertifi2026.10.19 and pip 26.2.2. pip vendors its own CA bundle, so the pip that ships with an older Python keeps trusting the root until pip itself is upgraded.The
publishjob ran on Python 3.10, whose bundled pip predates the fix. That pip installsbuildandtwine, themake package/make publishinstalls (pip3, sinceUVisn't set), andpython -m build's isolated setuptools environment. All of this runs in a job that holds the PyPI and private-index credentials.Changes:
python-version: '3.10'→'3.13'. 3.13.17 is available insetup-python's version list and bundles pip 26.2.2+. Changing the interpreter avoids upgrading pip through the vulnerable pip.User impact: none. The interpreter only runs
build/twine. The package is pure Python andrequires-pythonstays>=3.9.Test Plan
pyproject-build): it produces the sdist andsqlmesh-…-py3-none-any.whlwithRequires-Python: >=3.9.RECORD), same version.Checklist
make styleand fixed any issues (workflow YAML only)make fast-test) (no Python changes)git commit -s) per the DCOFollow-up worth considering separately: switch publishing to PyPI Trusted Publishing so the job holds no long-lived PyPI password.