Repository navigation
fix(manifest): keep the paths of a module excluded with --exclude-paths - #1650
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 3 commits intoOct 23, 2026
Conversation
Jeppe Fredsgaard Blaabjerg (jfblaa)
added this pull request to stack #1651
October 23, 2026 12:11
Jeppe Fredsgaard Blaabjerg (jfblaa)
removed this pull request from stack #1651
October 23, 2026 12:11
Jeppe Fredsgaard Blaabjerg (jfblaa)
added this pull request to stack #1652
October 23, 2026 12:12
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/facts-excluded-project-paths
branch
from
October 23, 2026 12:33
2bc2492 to
bd1e619
Compare
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/facts-excluded-project-paths
branch
from
October 23, 2026 12:44
bd1e619 to
d77a2ef
Compare
Martin Torp (mtorp)
approved these changes
Oct 23, 2026
Martin Torp (mtorp)
left a comment
Martin Torp (mtorp)
left a comment
Contributor
There was a problem hiding this comment.
[agent] Approving, with one design question inline.
An excluded module emitted no project record, so its sources and classpath vanished from the sidecar and the kept projects depending on it were analysed without its code. The Maven, Gradle and sbt producers now emit an excludedProject record for it under --with-files: it gets no project of its own, but its paths stay.
An excluded build module gets no project of its own, yet its code is still analysed through the projects that depend on it; the flag's help now says so. The changelog lists the JVM failures that now fail the run under Changed, with how to proceed past them. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…dule Co-Authored-By: Claude Opus 5.5 <[email protected]>
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/facts-excluded-project-paths
branch
from
October 23, 2026 17:10
d77a2ef to
9aa5e32
Compare
Jeppe Fredsgaard Blaabjerg (jfblaa)
deleted the
jfblaa/facts-excluded-project-paths
branch
October 23, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
A module excluded with
--exclude-pathslost its paths, so the kept projects depending on it were analysed without its code.excludedProjectrecord: the module gets no project of its own, but its source and classpath paths stay in the sidecar.--with-files.Testing: new assembler unit test. The full Gradle, Maven and sbt compat matrix passes on this PR; the stack's net diff equals #1642 minus #1643.
🤖 Generated with Claude Code
Note
Medium Risk
Changes JVM manifest and reachability path wiring for
--exclude-pathsacross Maven, Gradle, and sbt; incorrect handling could mis-attribute code paths in dependent-project analysis.Overview
Fixes
--exclude-pathsso excluded JVM submodules no longer drop their source and output paths from Socket facts. Dependent modules that stay in the scan were analyzed without the excluded library’s code because path records were omitted when a module was skipped as its own project.Introduces an
excludedProjectline-protocol record (with--with-files) in the Maven, Gradle, and sbt facts producers: excluded modules still emitprojectSrc/projectTgtbut no standaloneprojectentry. The TypeScript parser moves those entries intoexcludedProjects, andbuildArtifactPathsmerges them with kept projects sopathsByIdincludes the excluded module when something depends on it. Factsprojectslists only non-excluded modules; classpath maps stay keyed to kept projects only.Reviewed by Cursor Bugbot for commit 2bc2492. Configure here.