Repository navigation
fix the menu, preserve action identity when lazy items reorder - #913
Closed
SharonStrats wants to merge 2 commits into
Closed
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Slot collisions can select the wrong action, reordering can lose keyboard focus, and missing lockfile peers can block clean installs.
2 open issues
What changed in this PR
This PR updates resource-action menus to address action identity when lazy-loaded items reorder, supporting the folder-view and pane-menu fixes.
Changes:
- Adds optional action keys and keyed rendering to resource menu items.
- Derives menu slots from explicit keys, with positional fallbacks.
- Updates dependency classifications and placement in the lockfile.
| File | Description |
|---|---|
| src/components/resource-actions-menu/ResourceActionsMenu.ts | Adds action keys and passes them to menu items. |
| src/components/menu/Menu.ts | Adds keyed dropdown rendering and key-derived slot names. |
| package-lock.json | Reclassifies dependencies, relocates type entries, and removes React type peers. |
Review effort: Balanced
SharonStrats
force-pushed
the
fix/loading
branch
from
October 26, 2026 08:03
f3061b2 to
28d0dd1
Compare
Collaborator
Author
|
We don't need this anymore. It works without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contents was not showing the folder view and the pane was not appearing in the menu, this is needed to help fix that.
i had to add the solid-ui-menu because we want the resource items to be in a particular order. The primary pane first, contents and then the other panes.