Repository navigation
fix(data-grid): mount accessibility cells for rows a read prepared before they came on screen - #3891
Merged
Merged
Conversation
…fore they came on screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showStructure) prepares every row while none is on screen, so no row gets itsdata-grid-cellstand-in, and AppKit never asks for a prepared row again. Growing is not a scroll, so nothing remounted them.StructureSaveConfirmationUITestson main: all four failure trees (runs 40967120404, 40966363060) show the onlydata-gridwith its 3 rows and no stand-in, so the test was not matching a different grid and the columns did load..claude/rules/data-grid.md, Accessibility: when on-screen rows remount.Test plan
DataGridAccessibilityMountTests, 25 repetitions each: on main, "read before it grows" and "moved onto the page" fail 25 of 25 (no row ever mounts); here all three pass 25 of 25.DataGridControllerTests,StructureListGridAccessibilityTests,DataGridFittingHeightTests,DataGridViewportTests,DataGridEditingTests,DataGridMountTests): 91 of 91.StructureSaveConfirmationUITestsruns in CI's UI plan; Automation Mode is off on the dev Mac.