Repository navigation
Add semantic breadcrumbs to partner detail pages - #1463
Conversation
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Generate and render partner breadcrumbs src/utils/partner-breadcrumbs.ts, src/routes/partners.$partner.tsx, tests/partner-breadcrumbs.test.ts |
Helpers generate partner breadcrumb items and position-numbered JSON-LD entries with canonical URLs. The partner detail route renders the items through Breadcrumbs and adds the breadcrumb data to its JSON-LD. Tests check labels, paths, positions, and URLs. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- TanStack/tanstack.com#1461: Adds the shared
Breadcrumbsitems contract and uses it for visible blog breadcrumbs andBreadcrumbListdata. - TanStack/tanstack.com#1462: Changes shared
Breadcrumbslink matching, which affects current-page state for partner breadcrumb items.
Suggested reviewers: ladybluenotes
Merge Risk: 
Minimal · up to 78e4b
-
Partner pages show matching visible and structured breadcrumbs. No merge-blocking issue was identified.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Title check
-
Explanation
The title "Add semantic breadcrumbs to partner detail pages" matches the main change. The raw summary shows partner detail pages now render breadcrumbs through the shared Breadcrumbs component, and new helpers add a BreadcrumbList JSON-LD. The title is concise and specific. It does not mention the JSON-LD or the tests, which is acceptable.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 3 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 78e4bd2 | Commit Preview URL Branch Preview URL |
Nov 01 2026, 01:46 AM |
Partner detail pages already show a Partners → name trail, but it is a plain div and their structured data has no breadcrumb hierarchy. Reuse the semantic Breadcrumbs component and derive both its items and the WebPage’s BreadcrumbList from the same partner data.
Continues #1151 for the generic partner detail route. Bespoke partner pages, library landing pages, charts examples and the separate docs work remain outside this change, so this does not close the umbrella issue.
Validation: full
pnpm testand normal commit hooks; isolated actual-component RouterProvider/HeadContent SSR check for canonical URLs and escaped labels; 375px browser check for wrapping and keyboard navigation. Exact-commit Workers preview verified: canonical SSR breadcrumbs, desktop and 375px rendering, keyboard navigation to the partner directory, and unknown-partner 404 without breadcrumb metadata. Google Rich Results validation was not performed.