Skip to content

Add semantic breadcrumbs to partner detail pages - #1463

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/partner-breadcrumbs
Nov 1, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/partner-breadcrumbs

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Partner detail pages already show a Partners → name trail, but it is a plain div and their structured data has no breadcrumb hierarchy. Reuse the semantic Breadcrumbs component and derive both its items and the WebPage’s BreadcrumbList from the same partner data.

Continues #1151 for the generic partner detail route. Bespoke partner pages, library landing pages, charts examples and the separate docs work remain outside this change, so this does not close the umbrella issue.

Validation: full pnpm test and normal commit hooks; isolated actual-component RouterProvider/HeadContent SSR check for canonical URLs and escaped labels; 375px browser check for wrapping and keyboard navigation. Exact-commit Workers preview verified: canonical SSR breadcrumbs, desktop and 375px rendering, keyboard navigation to the partner directory, and unknown-partner 404 without breadcrumb metadata. Google Rich Results validation was not performed.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 78e4bd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3adb7283-047c-49c1-82ff-0b61d9b5e2d6
Commits

Reviewing files that changed from the base of the PR and between 8afddfd and 78e4bd2.

Files selected for processing: 3
  • src/routes/partners.$partner.tsx
  • src/utils/partner-breadcrumbs.ts
  • tests/partner-breadcrumbs.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Partner detail pages now render breadcrumbs through the shared Breadcrumbs component. New helpers provide partner breadcrumb items and BreadcrumbList JSON-LD, which the route adds to its existing JSON-LD data. Tests cover the breadcrumb labels, paths, positions, and canonical URLs.

Changes: Partner Breadcrumbs

Layer / File(s) Summary
Generate and render partner breadcrumbs
src/utils/partner-breadcrumbs.ts, src/routes/partners.$partner.tsx, tests/partner-breadcrumbs.test.ts
Helpers generate partner breadcrumb items and position-numbered JSON-LD entries with canonical URLs. The partner detail route renders the items through Breadcrumbs and adds the breadcrumb data to its JSON-LD. Tests check labels, paths, positions, and URLs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related PRs

  • TanStack/tanstack.com#1461: Adds the shared Breadcrumbs items contract and uses it for visible blog breadcrumbs and BreadcrumbList data.
  • TanStack/tanstack.com#1462: Changes shared Breadcrumbs link matching, which affects current-page state for partner breadcrumb items.

Suggested reviewers: ladybluenotes

Merge Risk: Minimal · up to 78e4b

Partner pages show matching visible and structured breadcrumbs. No merge-blocking issue was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Add semantic breadcrumbs to partner detail pages" matches the main change. The raw summary shows partner detail pages now render breadcrumbs through the shared Breadcrumbs component, and ne…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Add semantic breadcrumbs to partner detail pages" matches the main change. The raw summary shows partner detail pages now render breadcrumbs through the shared Breadcrumbs component, and new helpers add a BreadcrumbList JSON-LD. The title is concise and specific. It does not mention the JSON-LD or the tests, which is acceptable.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 78e4bd2 Commit Preview URL

Branch Preview URL
Nov 01 2026, 01:46 AM

@tannerlinsley
tannerlinsley merged commit fed7820 into main Nov 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/partner-breadcrumbs branch November 1, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant