Repository navigation
fix(showcase): keep default pagination out of the canonical URL - #1472
Conversation
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 0fc7350 | Commit Preview URL Branch Preview URL |
Nov 01 2026, 05:24 AM |
|
The exact commit preview now serves
|
The bare
/showcaseURL currently returns 307 to/showcase?page=1&pageSize=24, even though the canonical page is/showcase. Strip default search values with the existing Router middleware while keeping validated pagination defaults available to the loader. Filters and non-default pagination remain in the URL.Move the existing schema into a small importable module so the regression exercises the same validation without loading gallery services. The actual Router serialization test fails without the middleware and passes with it, including retained library, source-code, text and pagination filters.
This addresses the showcase redirect portion of #1153. Full preview HTTP verification is still pending, and the issue remains open for its other sitemap requirements.
Normal commit hooks passed formatting, TypeScript, lint, 688 unit tests, 2,278 chat tests and 20 desktop tests, with 5, 6 and 1 skipped respectively.