Skip to content

fix(showcase): keep default pagination out of the canonical URL - #1472

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/showcase-canonical-search
Nov 1, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/showcase-canonical-search

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

The bare /showcase URL currently returns 307 to /showcase?page=1&pageSize=24, even though the canonical page is /showcase. Strip default search values with the existing Router middleware while keeping validated pagination defaults available to the loader. Filters and non-default pagination remain in the URL.

Move the existing schema into a small importable module so the regression exercises the same validation without loading gallery services. The actual Router serialization test fails without the middleware and passes with it, including retained library, source-code, text and pagination filters.

This addresses the showcase redirect portion of #1153. Full preview HTTP verification is still pending, and the issue remains open for its other sitemap requirements.

Normal commit hooks passed formatting, TypeScript, lint, 688 unit tests, 2,278 chat tests and 20 desktop tests, with 5, 6 and 1 skipped respectively.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0fc7350

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f54d2942-9fb0-4665-88cc-4b3ca2c77d19
Commits

Reviewing files that changed from the base of the PR and between 020677d and 0fc7350.

Files selected for processing: 3
  • src/routes/showcase/index.tsx
  • src/utils/showcase-search.ts
  • tests/showcase-search.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 0fc7350 Commit Preview URL

Branch Preview URL
Nov 01 2026, 05:24 AM

@tannerlinsley

Copy link
Copy Markdown
Member Author

The exact commit preview now serves /showcase directly, and filtered pages still keep their noindex behavior.

AI review notes:
On 0fc7350, the commit preview at https://4b16a140-tanstack-com.thetanstack.workers.dev/showcase returned HTTP 200 without following redirects, with one canonical link to https://tanstack.com/showcase and no robots noindex directive. The same preview with page=2, pageSize=48 and q=dashboard returned HTTP 200, retained the base canonical and emitted noindex, nofollow. These are preview HTTP checks; production still awaits merge and deployment.

@tannerlinsley
tannerlinsley merged commit 5e9bb6d into main Nov 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/showcase-canonical-search branch November 1, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant