Skip to content

fix(seo): exclude internal implementation specs from sitemap - #1478

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/sitemap-internal-specs
Nov 1, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/sitemap-internal-specs

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

The sitemap includes an internal Devtools branding implementation specification under docs/superpowers/specs. Exclude the superpowers directory alongside the existing repository-artifact directories, while keeping public guides available.

Related to #1153. The documents themselves remain accessible.

AI review notes:
Read the upstream specification: it defines contributor ownership, internal token/build contracts, migration steps, and implementation acceptance criteria. The captured production sitemap includes one URL under this directory. The filter tests cover both specs and plans paths, with the existing public-guide controls retained. Normal commit hooks passed formatting, TypeScript, lint, unit, chat, and desktop checks. Deployed XML verification is pending.

Summary by CodeRabbit

  • Bug Fixes
    • Excluded documentation pages with “superpowers” in their slugs from the sitemap.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 208e2d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b4dfb6ab-8e60-4272-88d5-5594da26e1d4
Commits

Reviewing files that changed from the base of the PR and between cac1afb and 208e2d2.

Files selected for processing: 2
  • src/utils/sitemap-docs.ts
  • tests/sitemap-docs.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The documentation sitemap filter now excludes slugs containing the superpowers segment. Tests cover two superpowers documentation slugs and expect the filter to return false.

Changes: Documentation sitemap filtering

Layer / File(s) Summary
Exclude superpowers documentation slugs
src/utils/sitemap-docs.ts, tests/sitemap-docs.test.ts
The low-value segment list now includes superpowers. Tests expect two slugs containing that segment to be excluded.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 208e2

The sitemap change is narrowly scoped and covered by tests; it is mergeable with normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: excluding internal implementation specifications from the sitemap.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 208e2d2 Commit Preview URL

Branch Preview URL
Nov 01 2026, 06:10 AM

@tannerlinsley
tannerlinsley merged commit bfecac3 into main Nov 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/sitemap-internal-specs branch November 1, 2026 06:19
@tannerlinsley

Copy link
Copy Markdown
Member Author

The internal specification is now out of the production sitemap.

AI review notes:
The merge commit's Workers deployment succeeded. The fresh production sitemap contains 7,025 entries, with exactly the internal Devtools branding specification removed and no added URLs compared with the previous production snapshot. Blog modification dates are unchanged from the verified corrected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant