Skip to content

fix(matrix): raise TypeError for non-matrix input in multiply #15624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShoaibAbbasDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(matrix): raise TypeError for non-matrix input in multiply #15624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions matrix/matrix_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
if (
_check_not_integer(matrix_a)
and _check_not_integer(matrix_b)
and _verify_matrix_sizes(matrix_a, matrix_b)

Check warning on line 44 in matrix/matrix_operation.py

View workflow job for this annotation

GitHub Actions / ty

ty (redundant-condition) 

matrix/matrix_operation.py:44:13: redundant-condition: Expression `_verify_matrix_sizes(matrix_a, matrix_b)` is always truthy (has type `tuple[tuple[int, int], tuple[int, int]]`)
):
return [[i - j for i, j in zip(*m)] for m in zip(matrix_a, matrix_b)]
raise TypeError("Expected a matrix, got int/list instead")
Expand All @@ -66,8 +66,10 @@
>>> multiply([[1, 2, 3]], [[2], [3], [4]])
[[20]]
"""
if _check_not_integer(matrix_a) and _check_not_integer(matrix_b):
rows, cols = _verify_matrix_sizes(matrix_a, matrix_b)
if not (_check_not_integer(matrix_a) and _check_not_integer(matrix_b)):
raise TypeError("Expected a matrix, got int/list instead")

rows, cols = _verify_matrix_sizes(matrix_a, matrix_b)

if cols[0] != rows[1]:
msg = (
Expand Down
Loading