Repository navigation
fix(hashes): evaluate adler32 over bytes to resolve non-ASCII divergence - #15642
Open
saiyam-jain-dev wants to merge 1 commit into
Open
saiyam-jain-dev wants to merge 1 commit into
saiyam-jain-dev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Fixes #15635
Adler-32 is defined over a sequence of bytes.
hashes/adler32.pypreviously iterated over Unicode characters (ord(plain_chr)), which matched the reference Adler-32 specification (zlib.adler32) only for pure-ASCII text. Non-ASCII input (e.g.'€100','日本語テスト') and raw byte payloads produced checksums that diverged from standard implementations.This PR:
strandbytes/bytearraypayloads.zlib.adler32for all character sets.Checklist