Skip to content

fix(ciphers): operate on raw bytes in base32 and base85 - #15646

Closed
Nate-br wants to merge 2 commits into
TheAlgorithms:masterfrom
Nate-br:fix-base32-base85-bytes-encoding
Closed

Nate-br wants to merge 2 commits into
TheAlgorithms:masterfrom
Nate-br:fix-base32-base85-bytes-encoding

Conversation

@Nate-br

@Nate-br Nate-br commented Oct 26, 2026

Copy link
Copy Markdown

Describe your change:

Fixes #15636

ciphers/base32.py and ciphers/base85.py previously decoded input data using .decode("utf-8") and converted code points back via chr(). This caused non-ASCII text, characters >= U+0400, and arbitrary bytes to corrupt or raise UnicodeDecodeError.

This change updates both codecs to:

  • Operate directly on the raw input byte stream (data) without assuming UTF-8 string encoding.
  • Properly reconstruct and return raw bytes in both decode functions.
  • Add doctests covering non-ASCII byte strings (e.g. "héllo".encode()).

All doctests pass locally.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Nate-br, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant