Repository navigation
feat: Improve error message on connection failure #4207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simon-lemay-unity
wants to merge
5
commits into
develop-3.x.x
Choose a base branch
from
fix/improve-failed-connect-error
base: develop-3.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
35946d5
feat: Improve error message on connection failure
simon-lemay-unity ada4e86
Merge branch 'develop-3.x.x' into fix/improve-failed-connect-error
simon-lemay-unity a1c4fe0
chore: retrigger CI
NoelStephensUnity 70e742d
Merge develop-3.x.x into fix/improve-failed-connect-error
netcode-ci-service 4fcae59
Merge develop-3.x.x into fix/improve-failed-connect-error
netcode-ci-service File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encrypted WebGL clients with
UseWebSockets=falsereceive advice to switch to WebSockets even though WebSockets are already active. In WebGL player builds,CreateDriverselectsWebSocketNetworkInterfaceeven whenm_UseWebSocketsis false.LogClientConnectionFailureMessageinstead checks the serialized flag, so it incorrectly suggests that DTLS is involved. Determine whether WebSockets are effectively enabled, including the WebGL fallback. Use that result in both WebSocket checks inLogClientConnectionFailureMessage.🤖 Helpful? 👍/👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get a warning in the console when we end up using WebSockets even if
UseWebSocketsis false. It's not something that's supposed to happen on a correctly configured transport so I don't think it's worth handling here.