Repository navigation
refactor: blittable NetworkTransformState and reliability before serializing (batched transforms 4/5) - #4234
Draft
NoelStephensUnity wants to merge 2 commits into
Conversation
…lity before serializing Fourth of five PRs that replace #4123. NetworkTransformState drops its reader and writer fields so it can live in native memory, and UpdateReliability decides ReliableSequenced before the state is written. NetworkTransform routes its interpolators through helpers and computes its interpolation frame data once per update stage. NetworkTransformStateBaselineTests pins the serialized output.
This was referenced Oct 29, 2026
refactor: NetworkTransform delta detection as static job-safe methods (batched transforms 2/5)
#4232
Draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Makes
NetworkTransformStateblittable and decides its reliability before it is written, so a state can be queued and sent from native memory. The per-instance wire format is unchanged, andNetworkTransformStateBaselineTestspins it byte for byte.Stack (replaces #4123, review in order): #4231 math and handles → #4232 static delta check → #4233 native interpolator and sync mode setting → #4234 blittable state and reliability → #4235 batched send path. Each PR targets the branch of the one before it; the diff shown is that PR alone.
PR Scope:
NetworkTransformStatedrops its reader and writer fields.NetworkTransformState.UpdateReliability()derivesReliableSequencedbefore serializing, rather than insideNetworkSerialize. Behaviour change for reviewers: the half-float condition is nowSynchronizeBaseHalfFloatrather thanNetworkDeltaPosition.CollapsedDeltaIntoBase, so the serialized flag matches the delivery actually used.NetworkTransformreaches its three interpolators through helper methods, and the per-frame interpolation values are computed once per update stage onNetworkManagerinstead of once per instance.Out of scope:
Jira ticket
N/A
Changelog
NetworkTransformposition axis that drifted out of half float delta range while it was disabled did not teleport.Documentation
Testing & QA (How your changes can be verified during release Playtest)
NetworkTransformStateBaselineTestsrecords the exact serialized bytes of aNetworkTransformStateacross every serialization branch. If the wire format changes, it fails and prints the new table; a wire format change should also bump the NGO protocol version.NetworkTransformintegration tests cover the rest.Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
N/A (develop-3.x.x only).
Backports
No backport is required.